Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35739 )
Change subject: soc/intel/common/block: Update microcode serialized for HT threads ......................................................................
Patch Set 4:
(11 comments)
https://review.coreboot.org/c/coreboot/+/35739/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35739/4//COMMIT_MSG@7 PS4, Line 7: soc/intel/common/block: Update microcode serialiced for HT threads
serialized
Done
https://review.coreboot.org/c/coreboot/+/35739/4//COMMIT_MSG@9 PS4, Line 9: microcde
microcode
Done
https://review.coreboot.org/c/coreboot/+/35739/4//COMMIT_MSG@11 PS4, Line 11: "microcode: Update failed" error seen in the console log.
On what board? Or on all?
Done
https://review.coreboot.org/c/coreboot/+/35739/4//COMMIT_MSG@13 PS4, Line 13: state differently
… contradict each other. […]
Done
https://review.coreboot.org/c/coreboot/+/35739/4//COMMIT_MSG@13 PS4, Line 13: SDW
Does SDW stand for "Software Development (╯°□°)╯︵ lɐnuɐW"? 😄
Done
https://review.coreboot.org/c/coreboot/+/35739/4/src/cpu/intel/common/hypert... File src/cpu/intel/common/hyperthreading.c:
https://review.coreboot.org/c/coreboot/+/35739/4/src/cpu/intel/common/hypert... PS4, Line 40: = 0;
no need to initialize to 0 explicitly.
Done
https://review.coreboot.org/c/coreboot/+/35739/4/src/cpu/intel/common/hypert... PS4, Line 46: 1;
this value shouldn't be open coded. SPIN_LOCK_UNLOCKED definition should be used.
Done
https://review.coreboot.org/c/coreboot/+/35739/4/src/cpu/intel/common/hypert... PS4, Line 53: /* Is Hyper-Threading supported */ : if (!(cpuid_edx(1) & CPUID_FEAURE_HTT)) : return; :
This is duplicated below. […]
Done
https://review.coreboot.org/c/coreboot/+/35739/4/src/cpu/intel/common/hypert... PS4, Line 57: if (!initialized)
Sorry, read it a few times more. You mean, we don't know CONFIG_MAX_CPUS, […]
Done
https://review.coreboot.org/c/coreboot/+/35739/4/src/soc/intel/common/block/... File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/c/coreboot/+/35739/4/src/soc/intel/common/block/... PS4, Line 40: Tests
For which parts? There are many different implementations.
Done
https://review.coreboot.org/c/coreboot/+/35739/4/src/soc/intel/common/block/... PS4, Line 42: and updates one
Some word seems to be missing here.
Done