Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43603 )
Change subject: Documentation: Add documentation for resource allocator ......................................................................
Patch Set 1:
(12 comments)
Thank you for adding this.
https://review.coreboot.org/c/coreboot/+/43603/1/Documentation/device/resour... File Documentation/device/resource_allocation.md:
PS1: Maybe it’s just for review, but it’d be great, if you wrapped the lines.
https://review.coreboot.org/c/coreboot/+/43603/1/Documentation/device/resour... PS1, Line 5: viz. I learned something new: https://en.wikipedia.org/wiki/Viz. ;-)
Maybe, just use a colon (:) instead?
https://review.coreboot.org/c/coreboot/+/43603/1/Documentation/device/resour... PS1, Line 21: independent independently?
https://review.coreboot.org/c/coreboot/+/43603/1/Documentation/device/resour... PS1, Line 24: IORESOURCE_IO Mark this up as monospace with `…`?
https://review.coreboot.org/c/coreboot/+/43603/1/Documentation/device/resour... PS1, Line 27: “bridge resources” Ditto.
https://review.coreboot.org/c/coreboot/+/43603/1/Documentation/device/resour... PS1, Line 27: “fixed resources” I’d just mark them up as italic with *fixed resources*.
https://review.coreboot.org/c/coreboot/+/43603/1/Documentation/device/resour... PS1, Line 32: Both the flags
Both flags …
https://review.coreboot.org/c/coreboot/+/43603/1/Documentation/device/resour... PS1, Line 34: (IO / MEM) I’d remove the spaces.
https://review.coreboot.org/c/coreboot/+/43603/1/Documentation/device/resour... PS1, Line 48: Currently, there are two flavors of resource allocators implemented in coreboot - v3 and v4. Remove the trailing space.
https://review.coreboot.org/c/coreboot/+/43603/1/Documentation/device/resour... PS1, Line 70: * Finds a single window for resource allocation towards the top of addressable memory under 4G boundary. That’s exactly the same item as above.
https://review.coreboot.org/c/coreboot/+/43603/1/Documentation/device/resour... PS1, Line 81: DFS Please spell it out, or add a link.
https://review.coreboot.org/c/coreboot/+/43603/1/Documentation/device/resour... PS1, Line 89: Please remove the blank line at the end of the file.