Attention is currently required from: Nico Huber, Angel Pons. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48236 )
Change subject: mb/emulation/qemu-q35: Account for TSEG ......................................................................
Patch Set 8:
(4 comments)
File src/mainboard/emulation/qemu-i440fx/memmap.c:
https://review.coreboot.org/c/coreboot/+/48236/comment/5f1ce8a8_f1d37f5a PS8, Line 56: uintptr_t
size_t
Done
https://review.coreboot.org/c/coreboot/+/48236/comment/a3cdccc8_dc01f5d6 PS8, Line 57: smm_base
top ?
Done
File src/mainboard/emulation/qemu-q35/memmap.c:
https://review.coreboot.org/c/coreboot/+/48236/comment/a3b35352_761a691f PS8, Line 25: esmramc
Should we check the enable bit?
The lock + enable bits are only set at the end of SMM relocation in the follow up patch. So TSEG needs to be accounted for early on.
https://review.coreboot.org/c/coreboot/+/48236/comment/3b6c5226_50a2e1a8 PS8, Line 42: 0x%08lx
%p ?
that's for void *. *start is of type uintptr_t