[coreboot-gerrit] Change in ...coreboot[master]: src/device/pci: Add support for discrete VGA initialization and OpROM...

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31448 )

Change subject: src/device/pci: Add support for discrete VGA initialization and OpROM loading
......................................................................

Patch Set 1:
> > Not sure how you could even run two option roms without
> > redoing the routing in between.
>
> I'm not sure about this. But a hunch tells me that the
> option rom shouldn't assume the routing but check it and
> act accordingly.

I was looking at that AMD NB code, seemed to touch non-standard PCI config registers. Well, maybe standard to HyperTransport but still outside PCI bridge header specs.