Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34497 )
Change subject: mb/google/drallion: Add new mainboard ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34497/5/src/mainboard/google/dralli... File src/mainboard/google/drallion/romstage.c:
https://review.coreboot.org/c/coreboot/+/34497/5/src/mainboard/google/dralli... PS5, Line 62: cometlake_memcfg_init
I think this should be cannonlake_memcfg_init, hatch uses cannonlake_memcfg_init as well.
Done
https://review.coreboot.org/c/coreboot/+/34497/5/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/34497/5/src/mainboard/google/dralli... PS5, Line 1: cometlake
yes it does, sorry I should have taken a closer look before recommending this.
Done