Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32701 )
Change subject: arch/cpu: Rename mp_get_apic_id() and add_cpu_map_entry() function ......................................................................
Patch Set 3: Code-Review+2
(8 comments)
https://review.coreboot.org/#/c/32701/2/src/arch/x86/cpu.c File src/arch/x86/cpu.c:
https://review.coreboot.org/#/c/32701/2/src/arch/x86/cpu.c@222 PS2, Line 222: struct cpu_map {
Done
Ack
https://review.coreboot.org/#/c/32701/2/src/arch/x86/cpu.c@231 PS2, Line 231: const struct cpu_info *info
Done
Ack
https://review.coreboot.org/#/c/32701/2/src/arch/x86/cpu.c@233 PS2, Line 233: cpuid_ebx(1) >> 24
Done
Ack
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c@a142 PS1, Line 142:
I would split this up. It seems `dev` is only used locally here to provide […]
Done
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c@a592 PS1, Line 592:
thanks Nico, i will modify. […]
Done
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c@200 PS1, Line 200: info->cpu = dev_find_path(NULL, DEVICE_PATH_CPU_CLUSTER);
I would definitely prefer to keep the ordering of dev assignment. […]
Done (sort of)
https://review.coreboot.org/#/c/32701/1/src/cpu/x86/mp_init.c@976 PS1, Line 976: MP_FR_BLOCK_APS(mp_initialize_cpu, mp_initialize_cpu),
Ya. I don't think we should have so much churn in this change. […]
Done
https://review.coreboot.org/#/c/32701/2/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/32701/2/src/cpu/x86/mp_init.c@138 PS2, Line 138: struct cpu_device_map {
Done
Ack