Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46042 )
Change subject: vendorcode/google/chromeos: Add camera info ......................................................................
Patch Set 1:
Patch Set 1:
Given vendorcode/google/chromeos is only picked when CONFIG_CHROMEOS is defined (see next CL), I'm now wondering should we move this to driver/camera given this is actually a hardware information that will be needed (for identifying SKU) on Chromebooks, not just devices running ChromeOS.
@tfiga, do you think such code should still live in google/chromeos, or move to src/drivers/[camera?] ?
I guess ideally it would make sense to allow building this without CONFIG_CHROMEOS, although I wonder if in practice that would ever happen? Does anyone ever attempt to build coreboot for a Chromebook without CONFIG_CHROMEOS?
My preference would be something like drivers/camera/chromeos-eeprom.c, but I don't have much experience with coreboot, so please do whatever appropriate. :)