Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32229 )
Change subject: util/lint: Make usage of IS_ENABLED() an error
......................................................................
Patch Set 2:
(2 comments)
This change is ready for review.
https://review.coreboot.org/#/c/32229/1/util/lint/kconfig_lint
File util/lint/kconfig_lint:
https://review.coreboot.org/#/c/32229/1/util/lint/kconfig_lint@296
PS1, Line 296: sub check_is_enabled {
Rename the function too?
Done
https://review.coreboot.org/#/c/32229/1/util/lint/kconfig_lint@320
PS1, Line 320: } elsif ( $line =~ /^([^:]+):(\d+):(.+IS_ENABLED.*)/ ) {
I think you might also just kill all the IS_ENABLED() code completely? If you take out the macro its […]
I think it's better to keep it for now, as long as we have the definition
in libpayload.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32229
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id30ffa0089cec6c24fc3dbbb10a1be35f63b3d89
Gerrit-Change-Number: 32229
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 30 May 2019 12:45:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment