[coreboot-gerrit] Change in ...coreboot[master]: util/lint: Make usage of IS_ENABLED() an error

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32229 )

Change subject: util/lint: Make usage of IS_ENABLED() an error
......................................................................


Patch Set 2:

(2 comments)

This change is ready for review.

https://review.coreboot.org/#/c/32229/1/util/lint/kconfig_lint 
File util/lint/kconfig_lint:

https://review.coreboot.org/#/c/32229/1/util/lint/kconfig_lint@296 
PS1, Line 296: sub check_is_enabled {
> Rename the function too?
> Done

https://review.coreboot.org/#/c/32229/1/util/lint/kconfig_lint@320 
PS1, Line 320:         } elsif ( $line =~ /^([^:]+):(\d+):(.+IS_ENABLED.*)/ ) {
> I think you might also just kill all the IS_ENABLED() code completely? If you take out the macro its […]
> I think it's better to keep it for now, as long as we have the definition
> in libpayload.