Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33116 )
Change subject: Kconfig: Make stage cache kconfig selection proper
......................................................................
Patch Set 27:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33116/21/src/cpu/intel/smm/gen1/smm...
File src/cpu/intel/smm/gen1/smmrelocate.c:
https://review.coreboot.org/c/coreboot/+/33116/21/src/cpu/intel/smm/gen1/smm...
PS21, Line 124: if (CONFIG(USE_EXTERNAL_STAGE_CACHE)) {
The conditional here needs to evaluate true with TSEG only. […]
If the implementation places cache outside TSEG, it is wrong to carve out SMM_RESERVED_SIZE here based on USE_EXTERNAL_STAGE_CACHE. Code here would be fine if we evaluated CONFIG(TSEG_STAGE_CACHE) instead as it would imply the reservation needs to be made.
Also:
* I think CBMEM vs TSEG is better symmetry in naming than CBMEM vs "somewhere else"
* We may want to deprecate CBMEM as stage cache as a security measure. From what I know CBMEM is mutable from OS (gaining root priviledges on /dev/mem might be enough on some cases?)
* Some platforms have configurable TSEG size, we should assert at buildtime there is room for cache. I would be willing to always enable max TSEG regions for all platforms though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45e894ad335a4661cc7916b3768e1614a038b31c
Gerrit-Change-Number: 33116
Gerrit-PatchSet: 27
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 01 Aug 2019 15:52:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment