1 comment:
File src/cpu/intel/smm/gen1/smmrelocate.c:
Patch Set #21, Line 124: if (CONFIG(USE_EXTERNAL_STAGE_CACHE)) {
> The conditional here needs to evaluate true with TSEG only. […]
If the implementation places cache outside TSEG, it is wrong to carve out SMM_RESERVED_SIZE here based on USE_EXTERNAL_STAGE_CACHE. Code here would be fine if we evaluated CONFIG(TSEG_STAGE_CACHE) instead as it would imply the reservation needs to be made.
Also:
* I think CBMEM vs TSEG is better symmetry in naming than CBMEM vs "somewhere else"
* We may want to deprecate CBMEM as stage cache as a security measure. From what I know CBMEM is mutable from OS (gaining root priviledges on /dev/mem might be enough on some cases?)
* Some platforms have configurable TSEG size, we should assert at buildtime there is room for cache. I would be willing to always enable max TSEG regions for all platforms though.
To view, visit change 33116. To unsubscribe, or for help writing mail filters, visit settings.