15 Feb
2022
15 Feb
'22
1:32 p.m.
Attention is currently required from: Elyes Haouas. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35490 )
Change subject: drivers/i2c/at24rf08c: Cache devices associated with this driver ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/at24rf08c/lenovo_serials.c:
https://review.coreboot.org/c/coreboot/+/35490/comment/5535da22_764f8d7d PS2, Line 214: if (s != NULL) : return s;
this will never happen, right ? […]
`s` is static, i.e. not a local stack variable. So it can have different values if the function is called multiple times.
--
To view, visit https://review.coreboot.org/c/coreboot/+/35490
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I11eade2cea924839f4b1e1eeee612931fdfd1299
Gerrit-Change-Number: 35490
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Elyes Haouas ehaouas@noos.fr
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Tue, 15 Feb 2022 12:32:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas ehaouas@noos.fr
Gerrit-MessageType: comment