[coreboot-gerrit] Patch set updated for coreboot: southbridge: Remove trailing space in `dump_south()` output

[Paul Menzel]

Paul Menzel ([e-mail]) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/5179

-gerrit

commit f03f3c23029104f96263854491571fecd2671bf4
Author: Paul Menzel 
Date:   Mon Feb 10 11:46:52 2014 +0100

southbridge: Remove trailing space in `dump_south()` output

Change-Id: I4df9f8ce1058a2bb219508d0c8d04e153d37131c
    Signed-off-by: Paul Menzel 
---
 src/southbridge/amd/cs5535/cs5535.c   |  4 +-
 src/southbridge/via/vt8235/vt8235.c   | 89 -----------------------------------
 src/southbridge/via/vt8237r/vt8237r.c |  4 +-
 3 files changed, 4 insertions(+), 93 deletions(-)

diff --git a/src/southbridge/amd/cs5535/cs5535.c b/src/southbridge/amd/cs5535/cs5535.c
index 42707c0..9130a68 100644
--- a/src/southbridge/amd/cs5535/cs5535.c
+++ b/src/southbridge/amd/cs5535/cs5535.c
@@ -57,9 +57,9 @@ static void dump_south(struct device *dev)
    int i, j;

for(i=0; i<256; i+=16) {
-		printk(BIOS_DEBUG, "0x%02x: ", i);
+		printk(BIOS_DEBUG, "0x%02x:", i);
    	for(j=0; j<16; j++)
-			printk(BIOS_DEBUG, "%02x ", pci_read_config8(dev, i+j));
+			printk(BIOS_DEBUG, " %02x", pci_read_config8(dev, i+j));
    	printk(BIOS_DEBUG, "\n");
    }
 }
diff --git a/src/southbridge/via/vt8235/vt8235.c b/src/southbridge/via/vt8235/vt8235.c
deleted file mode 100644
index 4fa2784..0000000
--- a/src/southbridge/via/vt8235/vt8235.c
+++ /dev/null
@@ -1,89 +0,0 @@
-#include <console/console.h>
-#include <device/device.h>
-#include <device/pci.h>
-#include <device/pci_ops.h>
-#include <device/pci_ids.h>
-#include <pc80/keyboard.h>
-#include <pc80/i8259.h>
-#include "chip.h"
-
-static void keyboard_on(struct device *dev)
-{
-	u8 regval;
-
-	regval = pci_read_config8(dev, 0x51);
-	regval |= 0x05;
-	regval &= 0xfd;
-	pci_write_config8(dev, 0x51, regval);
-
-	pc_keyboard_init(0);
-}
-
-#ifdef UNUSED_CODE
-void dump_south(device_t dev0)
-{
-	int i,j;
-
-	for(i = 0; i < 256; i += 16) {
-		printk(BIOS_DEBUG, "0x%x: ", i);
-		for(j = 0; j < 16; j++) {
-			printk(BIOS_DEBUG, "%02x ", pci_read_config8(dev0, i+j));
-		}
-		printk(BIOS_DEBUG, "\n");
-	}
-}
-
-void set_led(void)
-{
-	// set power led to steady now that coreboot has virtually done its job
-	device_t dev;
-	dev = dev_find_device(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_8235, 0);
-	pci_write_config8(dev, 0x94, 0xb0);
-}
-#endif
-
-static void vt8235_enable(struct device *dev)
-{
-	u8 regval;
-	u16 vendor,model;
-
-	vendor = pci_read_config16(dev,0);
-	model = pci_read_config16(dev,0x2);
-
-	printk(BIOS_DEBUG, "In vt8235_enable %04x %04x.\n",vendor,model);
-
-	/* If this is not the southbridge itself just return.
-	 * This is necessary because USB devices are slot 10, whereas this
-	 * device is slot 11 therefore usb devices get called first during
-	 * the bus scan. We don't want to wait until we could do dev->init
-	 * because that's too late.
-	 */
-
-	if( (vendor != PCI_VENDOR_ID_VIA) || (model != PCI_DEVICE_ID_VIA_8235))
-		return;
-
-	printk(BIOS_DEBUG, "Initialising Devices\n");
-
-	/* make sure interupt controller is configured before keyboard init */
-	setup_i8259();
-
-	/* enable RTC and ethernet */
-	regval = pci_read_config8(dev, 0x51);
-	regval |= 0x18;
-	pci_write_config8(dev, 0x51, regval);
-
-	/* turn on keyboard */
-	keyboard_on(dev);
-
-	/* enable USB 1.1 & USB 2.0 - redundant really since we've
-	 * already been there - see note above
-	 */
-   	regval = pci_read_config8(dev, 0x50);
-	regval &= ~(0x36);
-	pci_write_config8(dev, 0x50, regval);
-}
-
-struct chip_operations southbridge_via_vt8235_ops = {
-	CHIP_NAME("VIA VT8235 Southbridge")
-	.enable_dev = vt8235_enable,
-};
diff --git a/src/southbridge/via/vt8237r/vt8237r.c b/src/southbridge/via/vt8237r/vt8237r.c
index 5f2449a..8848147 100644
--- a/src/southbridge/via/vt8237r/vt8237r.c
+++ b/src/southbridge/via/vt8237r/vt8237r.c
@@ -57,9 +57,9 @@ void dump_south(device_t dev)
    int i, j;

for (i = 0; i < 256; i += 16) {
-		printk(BIOS_DEBUG, "%02x: ", i);
+		printk(BIOS_DEBUG, "%02x:", i);
    	for (j = 0; j < 16; j++)
-			printk(BIOS_DEBUG, "%02x ", pci_read_config8(dev, i + j));
+			printk(BIOS_DEBUG, " %02x", pci_read_config8(dev, i + j));
    	printk(BIOS_DEBUG, "\n");
    }
 }