Andrew McRae has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44905 )
Change subject: mb/google/puff: Convert ASL file to new DPTF dt impl ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/duffy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 270: # Default DPTF Policy for all Puff boards if not overridden Is this comment still accurate? Maybe 'DPTF Policy for duffy'
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/faffy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44905/8/src/mainboard/google/hatch/... PS8, Line 276: device pci 04.0 on So I wonder whether faffy has the same policy as the others. I do see that it had a separate config from the others. I don't know about these configs as to whether the old config was just a placeholder for faffy.