Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31659 )
Change subject: mb/google/sarien: Remove DRIVERS_PS2_KEYBOARD ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review+1
Any idea why it was added in the first place?
The keyboard controller does not come up in translated mode, so unless I called keyboard_init() in coreboot it would never work in the kernel because it would come up as an "AT Raw" device instead of an "AT Translated".
In order to keep the keyboard untouched in coreboot (to try and minimize issues with keys pressed at boot) I put the workaround into the payload to put it into translate mode.
Thank you very much for the detailed answer. Could you please update the commit message accordingly?