Patch Set 1:

Patch Set 1: Code-Review+1

Any idea why it was added in the first place?

The keyboard controller does not come up in translated mode, so unless I called keyboard_init() in coreboot it would never work in the kernel because it would come up as an "AT Raw" device instead of an "AT Translated".

In order to keep the keyboard untouched in coreboot (to try and minimize issues with keys pressed at boot) I put the workaround into the payload to put it into translate mode.

Thank you very much for the detailed answer. Could you please update the commit message accordingly?

View Change

To view, visit change 31659. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I765e808f0d2589cf23c0349798a07e2706a2a7a4
Gerrit-Change-Number: 31659
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 28 Feb 2019 16:26:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment