Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45842 )
Change subject: soc/intel/xeon_sp/cpx: Move soc specific ACPI functions
......................................................................
Patch Set 2: Code-Review-2
(1 comment)
Code merged in previous patch didn't make it to this code being moved.
https://review.coreboot.org/c/coreboot/+/45842/2/src/soc/intel/xeon_sp/cpx/s...
File src/soc/intel/xeon_sp/cpx/soc_acpi.c:
https://review.coreboot.org/c/coreboot/+/45842/2/src/soc/intel/xeon_sp/cpx/s...
PS2, Line 376: static int get_stack_for_port(int p)
merged code didn't make it to this file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45842
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4aaca660e2f94d856676681417ae6c5d8c28a1f1
Gerrit-Change-Number: 45842
Gerrit-PatchSet: 2
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Sep 2020 21:23:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment