Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41232 )
Change subject: drivers/ocp/ipmi: Implement set POST start/end command ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41232/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41232/1//COMMIT_MSG@9 PS1, Line 9: Implemented to send POST start and POST end command to BMC in ramstage. Implemented to send --> Implemented sending.
Also please split this patch into two. One for drivers/ocp/ipmi, another for mb/ocp/tiogapass.
https://review.coreboot.org/c/coreboot/+/41232/1/src/drivers/ocp/ipmi/ipmi_o... File src/drivers/ocp/ipmi/ipmi_ocp.h:
https://review.coreboot.org/c/coreboot/+/41232/1/src/drivers/ocp/ipmi/ipmi_o... PS1, Line 1: /* This file is part of the coreboot project. */ Instead we just need this single line: /* SPDX-License-Identifier: GPL-2.0-or-later */