Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33827 )
Change subject: wifi/Kconfig: Add new config MAINBOARD_HAS_NO_WIFI
......................................................................
Patch Set 3:
Elyes, can you please calm down. If I read "shit" one more
time, I'll likely give -2, too, and ignore further comments.
That you named it "MAINBOARD_HAS_NO_WIFI" shows that you
still didn't understand what the `default y` for the Intel
driver is about. It is about plug-in cards that somebody
might plug into a board. Not about something that ships
with the board. Just like somebody might plug an SATA
drive. With your argumentation we could as well disable
ATA spport by default unless somebody opts in.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33827
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaaab6df43968abada6397acf7402264dea669c21
Gerrit-Change-Number: 33827
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 30 Jun 2019 10:12:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
