Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34840 )
Change subject: intel/smm: Provide common smm_relocation_params
......................................................................
Patch Set 14: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34840/14/src/cpu/x86/Makefile.inc
File src/cpu/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/34840/14/src/cpu/x86/Makefile.inc@9
PS14, Line 9: # This is hacky.
And will break if there are multiple objects named smm_reloc_params and HAVE_SMI_HANDLER is enabled. Could you expand this comment to relfect that? Or add a Kconfig that pulls in this directory when the Kconfig is selected?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39c6cffee95433aea1a3c783b869eedfff094413
Gerrit-Change-Number: 34840
Gerrit-PatchSet: 14
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 14 Nov 2019 21:51:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment