Hello build bot (Jenkins), Matt DeVillier, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46324
to look at the new patch set (#2).
Change subject: soc/intel/broadwell: Revise SA lockdown sequence ......................................................................
soc/intel/broadwell: Revise SA lockdown sequence
There's no need to use reg-script for this. Plus, some registers are written twice, which makes no sense. Revise the locking steps as per the Broadwell BIOS specification, and put names to MCHBAR registers.
The resulting sequence is nearly identical to the one for Haswell.
Change-Id: I91cd0aa61ba6bc578c892c1a5bc973bf4c28d019 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/finalize.c M src/soc/intel/broadwell/include/soc/systemagent.h 2 files changed, 62 insertions(+), 32 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/46324/2