[coreboot-gerrit] Change in coreboot[master]: soc/intel/{apl,cnl,dnv,skl}: Skip ucode loading by FSP-T

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37187 )

Change subject: soc/intel/{apl,cnl,dnv,skl}: Skip ucode loading by FSP-T
......................................................................

Patch Set 3:
> > > > > Tested on Coffeelake RVP11 with FSP_CAR selected, can boot successfully.
> > > >
> > > > Thanks. Can you share your defconfig and tell us which commit and what
> > > > FSP binary you used?
> > >
> > > i have tested on latest commit "a4f5954159531cfbe22a0b54acab331231440915" and FSP binaries are  from "3rdparty/fsp/CoffeeLakeFspBinPkg/".
> >
> > You mean a4f59541 with your patch on top?
> > > please suggest How to share defconfig ?
> >
> > `make savedefconfig` generates a file called `defconfig` in the source
> > root. Usually it's not long, so you can paste it here, or put it on
> > dpaste.com or alike.
>
> yes, my patch on top of a4f59541.
>
> defconfig: http://dpaste.com/2093NBB

Thanks for the details. For what it's worth, I wasn't able to reproduce
your success. Somehow it hangs and I have little means to debug things
pre-console. We have no business interest in FSP-T, so I'll just leave
it be.