Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41364 )
Change subject: nb/intel/sandybridge: add resources during read_resources() ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41364/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/41364/2/src/northbridge/intel/sandy... PS2, Line 130: mch Don't rename this, I'd rather use "dev" everywhere instead
https://review.coreboot.org/c/coreboot/+/41364/2/src/northbridge/intel/sandy... PS2, Line 139: pci_dev_read_resources(dev); See, "dev" is what we usually use 😉