Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45565 )
Change subject: mb/google/zork/vilboz: Enable SAR proximity sensor STH9324 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45565/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/gpio.c:
https://review.coreboot.org/c/coreboot/+/45565/2/src/mainboard/google/zork/v... PS2, Line 10: bid_1_gpio_set_stage_ram
Is P-sensor interrupt used only on board with version 1 or all future board versions as well? If it […]
I will discuss that with our hardware team and update result later.
https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45565/1/src/mainboard/google/zork/v... PS1, Line 140: STH9324
I think it would be good to get the driver in before landing this change. […]
I appreciate the comment.
Here is the CL for kernel driver. https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2... We are going to verify the p snesor function is workable or not. I will keep you posted. Thank you.