Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45398 )
Change subject: soc/mediatek/mt8192: add pmif driver ......................................................................
Patch Set 31:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45398/28/src/soc/mediatek/mt8192/in... File src/soc/mediatek/mt8192/include/soc/pmif_spi.h:
https://review.coreboot.org/c/coreboot/+/45398/28/src/soc/mediatek/mt8192/in... PS28, Line 107: (
No need for parentheses.
Done
https://review.coreboot.org/c/coreboot/+/45398/28/src/soc/mediatek/mt8192/pm... File src/soc/mediatek/mt8192/pmif.c:
https://review.coreboot.org/c/coreboot/+/45398/28/src/soc/mediatek/mt8192/pm... PS28, Line 74: *data = 0;
yes, it is.
Ack