Attention is currently required from: Patrick Rudolph, Alexander Couzens.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32253 )
Change subject: Documentation: Add lenovo's PMH known registers
......................................................................
Patch Set 4:
(1 comment)
File Documentation/mainboard/lenovo/pmh.md:
https://review.coreboot.org/c/coreboot/+/32253/comment/6396f6a8_02529a57
PS4, Line 31: 512
at least the PMH/Thinker1 can address 10bit(1024bytes) with the SPI based protocol. […]
so should this be updated to 1024bytes or should we merge this as it is right now? i'd like to have this documentation in tree
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32253
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1891a6370123d9ee29d9e37e4b7b78b677343aed
Gerrit-Change-Number: 32253
Gerrit-PatchSet: 4
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 20 Feb 2022 18:38:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Couzens
lynxis@fe80.eu
Gerrit-MessageType: comment