Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37878 )
Change subject: util/mainboard/google: add support for Volteer
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37878/1/util/mainboard/google/kconf...
File util/mainboard/google/kconfig.py:
https://review.coreboot.org/c/coreboot/+/37878/1/util/mainboard/google/kconf...
PS1, Line 45: print('Unsupported baseboard "' + args.board + '"')
always be 4 spaces? and others
If there's an overall style change (for indent, etc), it should happen in a separate commit, instead of mixing with adding support for another board.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I084b6c50bb76af0d11dc86a96b3c3c434569a0dd
Gerrit-Change-Number: 37878
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 26 Dec 2019 16:29:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Gerrit-MessageType: comment