Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45177 )
Change subject: soc/amd/picasso: Adjust for memory Mhz fraction
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45177/2/src/soc/amd/picasso/dmi.c
File src/soc/amd/picasso/dmi.c:
https://review.coreboot.org/c/coreboot/+/45177/2/src/soc/amd/picasso/dmi.c@3...
PS2, Line 34: * e.g. 1333 Mhz == 1333.333 Mhz == 2666.666 MT/s == 26667 MT/s
What if it is 1466MHz which comes out to be 2933MT/s. I think it might be better to just have a table that does the conversion instead of doing the math here? Or just handle it in mosys as Jack commented.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45177
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc77c21932c68ee9f0ff0b8e35ae7b1a3732b322
Gerrit-Change-Number: 45177
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 08 Sep 2020 19:11:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment