John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39785 )
Change subject: soc/intel/tigerlake: Configure TCSS power management
......................................................................
Patch Set 19:
(3 comments)
Patch Set 19:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39785/19/src/soc/intel/tigerlake/ac...
File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/39785/19/src/soc/intel/tigerlake/ac...
PS19, Line 11: * USB device controller(xDCI), Thunderbolt DMA devices and Thunderbolt PCIe controlers.
'controlers' may be misspelled - perhaps 'controllers'?
Ack
https://review.coreboot.org/c/coreboot/+/39785/19/src/soc/intel/tigerlake/ac...
PS19, Line 11: * USB device controller(xDCI), Thunderbolt DMA devices and Thunderbolt PCIe controlers.
trailing whitespace
Ack
https://review.coreboot.org/c/coreboot/+/39785/19/src/soc/intel/tigerlake/ac...
File src/soc/intel/tigerlake/acpi/tcss_dma.asl:
https://review.coreboot.org/c/coreboot/+/39785/19/src/soc/intel/tigerlake/ac...
PS19, Line 126: * other thread's _PS0 to wait for the command completition. WACT is cleared to
'completition' may be misspelled - perhaps 'completion'?
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39785
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I127d3700ad426a44639ee93b4477be6638b42e1b
Gerrit-Change-Number: 39785
Gerrit-PatchSet: 19
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Cliff Huang
cliff.huang@intel.com
Gerrit-CC: Duncan Laurie
dlaurie@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.com
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Comment-Date: Tue, 14 Apr 2020 16:59:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment