Divya Sasidharan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42295 )
Change subject: soc/intel/tigerlake: Update TCSS for SW CM support
......................................................................
Patch Set 6:
Patch Set 2:
Patch Set 2: Code-Review+1
This is needed for SW CM power management support, also disables PCIe tunneling. TBT FW for this is already merged in CL:3107594.
Hi Divya; What will we need to do to re-enable it (from the kernel)? A few folks on our side are looking at PCIe related behaviour (IOMMU enablement, resource allocation etc), so would be good to know if this is something that can be re-enabled via sysfs or kernel command line.
Based on verification we see no impact with this bit set / clear for PCIe tunneling. But from the comments we got, we understand that clearing this bit should disable the PCIe tunneling permanently. Since we do not want that at this point, in this CL we will keep this bit enabled. Latest patchset already addresses this. For disabling PCIe tunneling we can further discuss here 141545149.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42295
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I859c5075882e40d7be30d4ba88cc825886712b74
Gerrit-Change-Number: 42295
Gerrit-PatchSet: 6
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Prashant Malani
pmalani@chromium.org
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alex Levin
levinale@google.com
Gerrit-CC: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-CC: Prashant Malani
pmalani@google.com
Gerrit-CC: Rajat Jain
rajatja@google.com
Gerrit-CC: Rajmohan Mani
rajmohan.mani@intel.com
Gerrit-CC: Tanu Malhotra
tanu.malhotra@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 18 Jun 2020 23:07:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment