Attention is currently required from: Bora Guvendik, Hannah Williams, Tarun Tuli.
Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72693 )
Change subject: vendorcode/intel/fsp: Expose DisableDynamicTccoldHandshake
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72693/comment/b8dab912_2e4b269c
PS1, Line 12: BUG=None
: TEST=Boot to OS, check UPD value in debug FSP build.
shouldn't we have a bug for it ?
Don't we want it on the firmware branch ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72693
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0d953f37a2f0dac58fd339e3fe0dc847d5e6d892
Gerrit-Change-Number: 72693
Gerrit-PatchSet: 1
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Comment-Date: Fri, 03 Feb 2023 02:59:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment