EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39678 )
Change subject: mb/google/deltaur: Provide initial devicetree ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 53: 0 Should be 1?
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 73: register "PcieClkSrcUsage[6]" = "PCIE_CLK_NOTUSED" I think you miss 7 here.
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 99: .speed = I2C_SPEED_FAST, TPM need early_init = 1, right?
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 236: end Do we need device usb 3.x as well?
https://review.coreboot.org/c/coreboot/+/39678/3/src/mainboard/google/deltau... PS3, Line 277: device pci 1c.7 on end # PCIe Root Port #8 (LAN) chip drivers/net register "wake" = "PME_B0_EN_BIT" ?? device pci 00.0 on end end