18 Aug
2023
18 Aug
'23
4:56 p.m.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76927?usp=email )
Change subject: drivers/intel/fsp2_0: Add configurable compression for logo cbfs file ......................................................................
Patch Set 8:
(1 comment)
File src/drivers/intel/fsp2_0/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76927/comment/71cd1798_bb4b376f : PS8, Line 109: else ($(CONFIG_BMP_LOGO_COMPRESS_LZ4),y)
Make complains:
src/drivers/intel/fsp2_0/Makefile.inc:109: extraneous text after 'else' directiveThere's an `ifeq` missing.
although this statement looks different bt it serves the purpose and i don't see any compilation failure.
CB:77286 should still fix this problem
--
To view, visit https://review.coreboot.org/c/coreboot/+/76927?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0aa5320632ae3f734004d2b1d495af11c2e1928
Gerrit-Change-Number: 76927
Gerrit-PatchSet: 8
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-Reviewer: Martin L Roth gaumless@gmail.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Fri, 18 Aug 2023 14:56:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment