Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34752 )
Change subject: arch/x86: Attempt to boot without postcar stage/phase ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/34752/3/src/arch/x86/c_start.S File src/arch/x86/c_start.S:
https://review.coreboot.org/c/coreboot/+/34752/3/src/arch/x86/c_start.S@45 PS3, Line 45: ramstage_start:
This doesn't need to be in the else. It's just a symbol.
agree
https://review.coreboot.org/c/coreboot/+/34752/3/src/arch/x86/c_start.S@48 PS3, Line 48: lgdt %cs:gdtaddr
Do we want to load 2 different gdts successively? Or remove the first one in exit_car. […]
yes, we don;t need gdtinit in exit_car.S when we are doing the same from here in case of ramstage tearing down CAR. i will try to get rid of exit_car.S and see what can be done here
https://review.coreboot.org/c/coreboot/+/34752/3/src/arch/x86/ramstage_loade... File src/arch/x86/ramstage_loader.c:
https://review.coreboot.org/c/coreboot/+/34752/3/src/arch/x86/ramstage_loade... PS3, Line 91:
Why is this file essentially duplicated? Can we not modify postcar_loader to handle the 2 different […]
yes can be done using some enum used as parameter to know if we wises to load fallback/postcar or fallback/ramstage
https://review.coreboot.org/c/coreboot/+/34752/3/src/lib/program.ld File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/34752/3/src/lib/program.ld@100 PS3, Line 100: #if ENV_RMODULE || ENV_POSTCAR || CONFIG(RAMSTAGE_LOADS_FROM_ROMSTAGE)
when ramstage is relocatable it already has this section. […]
agree, i can modify kconfig and make depends on relocatable ramstage
https://review.coreboot.org/c/coreboot/+/34752/3/src/soc/intel/cannonlake/Kc... File src/soc/intel/cannonlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/34752/3/src/soc/intel/cannonlake/Kc... PS3, Line 81: select RAMSTAGE_LOADS_FROM_POSTCAR
we wouldn't be switching over all these SoC with this patch. […]
do you misread this as RAMSTAGE_LOADS_FROM_ROMSTAGE ?
i didn't switch anything, its same as previous loading ramstage from postcar.
Just renamed RAMSTAGE_LOADS_FROM_POSTCAR from POSTCAR_STAGE to make it clear about 2 possible option
1. RAMSTAGE_LOADS_FROM_POSTCAR 2. RAMSTAGE_LOADS_FROM_ROMSTAGE