HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40813 )
Change subject: mb/ongy/h61m-s1: Add new mainboard
......................................................................
Patch Set 21:
(1 comment)
Patch Set 20:
Patch Set 20:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40813/20/src/mainboard/ongy/h61m-s1...
File src/mainboard/ongy/h61m-s1/early_init.c:
https://review.coreboot.org/c/coreboot/+/40813/20/src/mainboard/ongy/h61m-s1...
PS20, Line 4: include <device/mmio.h>
: #include <device/pci_ops.h>
: #include <device/pnp_ops.h>
: #include <bootblock_common.h>
: #include <northbridge/intel/sandybridge/sandybridge.h>
: #include <northbridge/intel/sandybridge/raminit_native.h>
: #include <southbridge/intel/bd82x6x/pch.h>
: #include <southbridge/intel/common/gpio.h>
Please include only what you use
Thx
(Merci)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40813
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f42ffdbbfb59a1b699ba49650919c1d538c8e6c
Gerrit-Change-Number: 40813
Gerrit-PatchSet: 21
Gerrit-Owner: Skoll RC
amisbievre@posteo.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Skoll RC
amisbievre@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 02 May 2020 19:47:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment