Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45878 )
Change subject: tigerlake mainboards: switch to devtree aliases for PMC MUX connectors ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45878/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45878/2/src/mainboard/google/voltee... PS2, Line 245: conn1
How does it know which conn1 reference one to use? I am surprised this doesn't error out with the a […]
Haha yeah, I did notice that but forgot about it. I think it'll just use the "first" one. find_alias is recursive though, so I would have thought it could find it... definitely buggy, but I mean semantically whichever one is successfully probed...
I wonder if maybe this isn't a bad thing... b/c in the end, only one or zero of them will be probed. What do you think about adding a check in fw_config after the init() to handle this case, to assign the alias back in chromeec to whichever one was probed successfully? We need more code to handle this case either way.