Srinidhi N Kaushik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47991 )
Change subject: soc/intel/common/fast_spi: Add support for configuring MTRRs ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47991/1/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/fast_spi.c:
https://review.coreboot.org/c/coreboot/+/47991/1/src/soc/intel/common/block/... PS1, Line 238: if (ENV_PAYLOAD_LOADER) { : mtrr_use_temp_range(ext_bios_base, ext_bios_size, type); : } else { : int mtrr = get_free_var_mtrr(); : : if (mtrr == -1) : return; : : set_var_mtrr(mtrr, ext_bios_base, ext_bios_size, type); : }
BTW, if you want to add the helper fast_spi_cache_ext_bios_postcar as part of this function, please […]
I have refactored and added fast_spi_cache_ext_bios_window, for postcar I was not sure how to populate pcf. Should I call fill_postcar_frame ?