Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40578 )
Change subject: mb/google/volteer: move mipi_camera.asl to variants folders ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40578/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/Kconfig:
https://review.coreboot.org/c/coreboot/+/40578/1/src/mainboard/google/voltee... PS1, Line 81: : config VARIANT_SPECIFIC_OPTIONS_HALVOR : def_bool n : : config VARIANT_SPECIFIC_OPTIONS_MALEFOR : def_bool n : : config VARIANT_SPECIFIC_OPTIONS_RIPTO : def_bool n : select VARIANT_HAS_MIPI_CAMERA : : config VARIANT_SPECIFIC_OPTIONS_VOLTEER : def_bool n : select VARIANT_HAS_MIPI_CAMERA I don't think you need VARIANT_SPECIFIC_OPTIONS_*. Instead you can directly select VARIANT_HAS_MIPI_CAMERA from Kconfig.name for variants that need it. Eventually, I am hoping we can get rid of this Kconfig anyways.