Maxim Polyakov has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/40736 )
Change subject: md/cedarisland_crb: rework GPIOs configuration using macros ......................................................................
md/cedarisland_crb: rework GPIOs configuration using macros
This format of PCH GPIOs configuration, unlike the raw DW0 and DW1 registers values from the inteltool dump, is more understandable and makes the code much cleaner. The gpio.h file with PAD_CFG macros was automatically generated using the util/intelp2m [1] utility:
./intelp2m -p lbg -file cedarisland/vendorbios/inteltool_gpio.log
According to the documentation [2], the Host Software Pad Ownership register only affects the pads that are configured as input. The intelp2m utility takes this into account when converting macros and ignores bits from this register for the corresponding pads. However, the PAD_CFG_GPO_GPIO_DRIVER() macros are still used, since these macros were added to the project for a long time ago and some motherboards use them in the configuration. The issue related to these macros should be resolved in a separate patch.
[1] https: //review.coreboot.org/c/coreboot/+/35643 [2] Intel Document Number: 549921
Change-Id: Id671a9021a8313d8c3359b89c2934b929bcab1a4 Signed-off-by: Maxim Polyakov max.senia.poliak@gmail.com --- M src/mainboard/intel/cedarisland_crb/include/gpio.h 1 file changed, 240 insertions(+), 240 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/40736/2