9 Dec
2020
9 Dec
'20
11:07 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48236 )
Change subject: mb/emulation/qemu-q35: Account for TSEG ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48236/7/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-q35/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48236/7/src/mainboard/emulation/qem... PS7, Line 10: postcar-y += memmap.c
Are this and the later entries needed? I thought since we pass the top […]
If it's going to be needed, probably not worth the hassle. Your call.
--
To view, visit https://review.coreboot.org/c/coreboot/+/48236
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fd82a42d6602f1369bb3c69556c46f537542705
Gerrit-Change-Number: 48236
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Wed, 09 Dec 2020 23:07:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans arthur@aheymans.xyz
Gerrit-MessageType: comment