Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35845 )
Change subject: mb/google/hatch: Initialize FPMCU_PCH_BOOT1
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35845/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35845/2//COMMIT_MSG@7
PS2, Line 7: :
"mb/google/hatch/var/dratini: " since this change is being made for just one variant.
Tim/Paul -- can you please check if this change is required for other variants too? In that case it can be done in baseboard/gpio.c
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35845
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I73a5c3529330ef3e72f4c7d5fcbbd2f6693494d8
Gerrit-Change-Number: 35845
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 07 Oct 2019 19:00:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment