build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31955 )
Change subject: soc/intel/icelake: Pass FSP-M/S UPD as per ICL requirement ......................................................................
Patch Set 14:
(4 comments)
https://review.coreboot.org/#/c/31955/14/src/soc/intel/icelake/fsp_params.c File src/soc/intel/icelake/fsp_params.c:
https://review.coreboot.org/#/c/31955/14/src/soc/intel/icelake/fsp_params.c@... PS14, Line 40: for (int i = 0; i < CONFIG_SOC_INTEL_I2C_DEV_MAX; i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31955/14/src/soc/intel/icelake/fsp_params.c@... PS14, Line 50: for (int i = 0; i < CONFIG_SOC_INTEL_UART_DEV_MAX; i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31955/14/src/soc/intel/icelake/fsp_params.c@... PS14, Line 70: for (i = 0; i < ARRAY_SIZE(params->Usb2OverCurrentPin); i++) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/31955/14/src/soc/intel/icelake/fsp_params.c@... PS14, Line 74: for (i = 0; i < ARRAY_SIZE(params->Usb3OverCurrentPin); i++) { braces {} are not necessary for single statement blocks