Attention is currently required from: Furquan Shaikh, Marshall Dawson, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51675 )
Change subject: mb/google/guybrush: Update GPIO configuration
......................................................................
Patch Set 10:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51675/comment/b496bbb6_e4bc1240
PS4, Line 11: Set PCIE_RST0_L to a GPIO and set it high to release the bus.
My understanding from zork(Picasso) is that PCIE_RST0_L is deasserted 'x' ms after PWRGOOD goes high […]
Done
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/51675/comment/136fb33f_15064393
PS3, Line 16: /* GSC_SOC_INT_L */
it was also new for me, but i think that it's a good idea and the additional overhead is minimal
Done
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/51675/comment/5f85137e_81b413f3
PS7, Line 57: PAD_GPO
No, that's not the problem. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51675
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I512cb8b435dc8412cd46189e741ad94e5a24699e
Gerrit-Change-Number: 51675
Gerrit-PatchSet: 10
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Mathew King
mathewk@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 31 Mar 2021 21:19:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment