Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76158?usp=email )
Change subject: acpi: Set checksum for SPCR table
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
The zeroes presented in generated SPCR possibly come from a later ACPI spec than what fwts is aware […]
Thanks for digging :) Arthur already created a PR at fwts fixing the issues https://github.com/ColinIanKing/fwts/pull/13. It's also linked in a comment on a change, but I can't find it now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76158?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0086a3e8c5b3a06da9edf40a7a288c534fc5a6b2
Gerrit-Change-Number: 76158
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Mon, 03 Jul 2023 07:55:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment