Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39084 )
Change subject: commonlib/timestamp_serialized.h: Drop outdated remark ......................................................................
Patch Set 1:
Patch Set 1:
Given the comment in the source where the symbol is used (src/lib/cbfs.c:145 /* Note: timestamp not useful for memory-mapped media (x86) */), I guess it's more the issue of not being very useful because it's CPU bound anyway (as compared to platforms where different access strategies can make a big difference).
If so, maybe we should guard the uses there with if (!CONFIG(BOOT_DEVICE_MEMORY_MAPPED)), so that there's no such entry in cbmem on x86 to begin with (and also drop the remark here)?
Well, it's nice to have these timestamps. Different (de)compression algorithms need different amounts of time to decompress things.