Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32648 )
Change subject: soc/amd/stoneyridge: Add IO access functions for PMx
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/32648/1/src/soc/amd/stoneyridge/sb_util.c
File src/soc/amd/stoneyridge/sb_util.c:
https://review.coreboot.org/#/c/32648/1/src/soc/amd/stoneyridge/sb_util.c@32
PS1, Line 32: for (i = sizeof(value) - 1 ; i >= 0 ; i--)
Why are you using a loop here? Why not just something like: […]
Only to match the style of biosram_*, although I can't seem to find the discussion history of how we'd settled on that before. I'll change it to what I prefer visually and see if it goes through without objection.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32648
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6e7ba472ef2551e363987d18a79408fcd2074de4
Gerrit-Change-Number: 32648
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 May 2019 22:28:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment