Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37116 )
Change subject: sb/ibexpeak: Use macros instead of hard-coded IDs ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37116/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37116/1//COMMIT_MSG@9 PS1, Line 9: This patch replaces hard-coded PCI IDs with macros : from pci_ids.h and adds the related IDs to it. : : The resulting binary doesn't differ from the one : without this patch.
Reflow for 75 characters.
Done
https://review.coreboot.org/c/coreboot/+/37116/2/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/37116/2/src/include/device/pci_ids.... PS2, Line 2718: #define PCI_DID_INTEL_IBEXPEAK_LPC_QM57 0x3b07
please, no space before tabs
Done
https://review.coreboot.org/c/coreboot/+/37116/2/src/include/device/pci_ids.... PS2, Line 2719: #define PCI_DID_INTEL_IBEXPEAK_LPC_HM55 0x3b09
please, no space before tabs
Done
https://review.coreboot.org/c/coreboot/+/37116/2/src/include/device/pci_ids.... PS2, Line 2721: #define PCI_DID_INTEL_IBEXPEAK_MOBILE_SATA_AHCI 0x3b29
please, no space before tabs
Done