Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42302 )
Change subject: mb/google/volteer/var/terrador: Update gpio settings and overridetree.cb ......................................................................
Patch Set 12:
(5 comments)
https://review.coreboot.org/c/coreboot/+/42302/12/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/terrador/gpio.c:
https://review.coreboot.org/c/coreboot/+/42302/12/src/mainboard/google/volte... PS12, Line 8: /* Leave eSPI pins untouched from default settings */ Please remove this comment. I noticed that variant/volteer/gpio.c also had this comment, so I have submitted a change to remove this comment from there as well. Thank you.
https://review.coreboot.org/c/coreboot/+/42302/12/src/mainboard/google/volte... PS12, Line 9: gpio_table Please name this "override_gpio_table" to make it more clear that this is an override table and not the base table.
https://review.coreboot.org/c/coreboot/+/42302/12/src/mainboard/google/volte... PS12, Line 193: gpio_table Please change to "override_gpio_table".
https://review.coreboot.org/c/coreboot/+/42302/12/src/mainboard/google/volte... PS12, Line 194: gpio_table Please change to "override_gpio_table".
https://review.coreboot.org/c/coreboot/+/42302/12/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/terrador/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42302/12/src/mainboard/google/volte... PS12, Line 17: device pci 15.0 on : chip drivers/i2c/generic : register "hid" = ""10EC5682"" : register "name" = ""RT58"" : register "desc" = ""Headset Codec"" : register "irq_gpio" = "ACPI_GPIO_IRQ_EDGE_BOTH(GPP_R5)" : # Set the jd_src to RT5668_JD1 for jack detection : register "property_count" = "1" : register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" : register "property_list[0].name" = ""realtek,jd-src"" : register "property_list[0].integer" = "1" : device i2c 1a on : end : end : chip drivers/i2c/max98373 : register "vmon_slot_no" = "0" : register "imon_slot_no" = "1" : register "uid" = "0" : register "desc" = ""Right Speaker Amp"" : register "name" = ""MAXR"" : device i2c 31 on : end : end : chip drivers/i2c/max98373 : register "vmon_slot_no" = "2" : register "imon_slot_no" = "3" : register "uid" = "1" : register "desc" = ""Left Speaker Amp"" : register "name" = ""MAXL"" : device i2c 32 on : end : end : end # I2C #0 0xA0E8 : Please rebase your change (https://review.coreboot.org/c/coreboot/+/42302) on top of this change (https://review.coreboot.org/c/coreboot/+/42550/) as it has already been +2'd and will merge before this CL, and it modifies terrador's overridetree.cb to add a couple of items.