Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41095 )
Change subject: superio/winbond/w83977tf: Fix iasl warning ......................................................................
superio/winbond/w83977tf: Fix iasl warning
The common PnP serial port DSDT code is intentionally included twice for two serial ports with different LDNs. Undefine LDN and the PM register name before redefining for second serial port so iasl doesn't complain.
Change-Id: I031905479c66698fb01da028e3f37d923396d2d9 Signed-off-by: Keith Hui buurin@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41095 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/superio/winbond/w83977tf/acpi/superio.asl 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/superio/winbond/w83977tf/acpi/superio.asl b/src/superio/winbond/w83977tf/acpi/superio.asl index cd514d0..6e37a5b 100644 --- a/src/superio/winbond/w83977tf/acpi/superio.asl +++ b/src/superio/winbond/w83977tf/acpi/superio.asl @@ -350,6 +350,8 @@ #define SUPERIO_UART_LDN W83977TF_SP1 #define SUPERIO_UART_PM_REG UAPW #include <superio/acpi/pnp_uart.asl> + #undef SUPERIO_UART_LDN + #undef SUPERIO_UART_PM_REG #endif
#ifdef SUPERIO_SHOW_UARTB