build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26353 )
Change subject: device/oprom/x86emu/prim_ops.c: Fix coding style ......................................................................
Patch Set 10:
(65 comments)
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c File src/device/oprom/x86emu/prim_ops.c:
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 195: if (set_carry) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 207: if (set_carry) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 297: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 316: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 765: if ((cnt = s % 9) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 812: if ((cnt = s % 17) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 817: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 836: if ((cnt = s % 33) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 883: if ((cnt = s % 9) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 888: /* note hackery here. Access_flag(..) evaluates to either line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 947: if ((cnt = s % 17) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 956: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 979: if ((cnt = s % 33) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 988: if (cnt != 1) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1028: if ((cnt = s % 8) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1061: if ((cnt = s % 16) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1086: if ((cnt = s % 32) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1126: if ((cnt = s % 8) != 0) { /* not a typo, do nada if cnt==0 */ do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1157: if ((cnt = s % 16) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1180: if ((cnt = s % 32) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1290: CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^ line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1325: if (cnt == 1) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1360: if (cnt == 1) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1362: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1362: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1394: if (cnt == 1) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1426: if (sf) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1464: if (sf) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1502: if (sf) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1578: CONDITIONAL_SET_FLAG((((res & 0x80000000) == 0x80000000) ^ line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1613: if (cnt == 1) { braces {} are not necessary for any arm of this statement
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1647: if (cnt == 1) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1649: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1649: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1672: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1674: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1674: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1696: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1698: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1698: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1720: if (ACCESS_FLAG(F_CF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1722: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1722: } else { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1938: if ((d_sign = d & 0x80000000) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1938: if ((d_sign = d & 0x80000000) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1943: if ((s_sign = s & 0x80000000) != 0) { do not use assignment in if condition
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 1943: if ((s_sign = s & 0x80000000) != 0) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2308: } else if (size == 2) { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2308: } else if (size == 2) { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2308: } else if (size == 2) { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2311: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2311: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2311: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2321: if (ACCESS_FLAG(F_DF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2356: } else { code indent should use tabs where possible
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2356: } else { please, no spaces at the start of a line
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2356: } else { space required after that close brace '}'
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2366: if (ACCESS_FLAG(F_DF)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2379: if (M.x86.mode & SYSMODE_32BIT_REP) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2475: /* Regardless if we have real data from the hardware, the emulator line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2476: * will only support upto feature 1, which we set in register EAX. line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2486: /* If we don't have x86 compatible hardware, we return values from an line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2487: * Intel 486dx4; which was one of the first processors to have CPUID. line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2493: /* In the case that we have hardware CPUID instruction, we make sure line over 80 characters
https://review.coreboot.org/#/c/26353/10/src/device/oprom/x86emu/prim_ops.c@... PS10, Line 2500: * return all zeros when queried for invalid or unsupported feature line over 80 characters